---
title: "When Culture and Code Reviews Collide, Communication is Key"
description: "The post examines how cultural differences in politeness, directness, and face-saving can distort written code reviews, causing useful feedback to be softened, misread, or ignored. It contrasts a passive-aggressive Shopify pull-request exchange about missing permalink tests with a more curious and explicit version that states why a separate test would be worthwhile. The discussion distinguishes assuming positive intent from asserting it: context can reduce bias, but it must not erase the impact of embarrassing or harmful communication. It recommends treating reviews as collaborative invitations, asking questions, explaining reasoning, acknowledging reviewers as contributors, and looking past stylistic language to shared goals. The conclusion is that clearer communication and shared ownership can make disagreement productive and improve both learning and the codebase."
---

# When Culture and Code Reviews Collide, Communication is Key

[Shopify](https://yomu.fyi/company/shopify) · 2023-10-18 · Aug 26, 2022

**Type:** Explainer

## Summary

The post examines how cultural differences in politeness, directness, and face-saving can distort written code reviews, causing useful feedback to be softened, misread, or ignored. It contrasts a passive-aggressive Shopify pull-request exchange about missing permalink tests with a more curious and explicit version that states why a separate test would be worthwhile. The discussion distinguishes assuming positive intent from asserting it: context can reduce bias, but it must not erase the impact of embarrassing or harmful communication. It recommends treating reviews as collaborative invitations, asking questions, explaining reasoning, acknowledging reviewers as contributors, and looking past stylistic language to shared goals. The conclusion is that clearer communication and shared ownership can make disagreement productive and improve both learning and the codebase.

## Context

Written code reviews invite critical feedback and conflict but lack verbal cues, so cultural differences in politeness, directness, and expectations around saving face can cause reviewers and authors to misread one another. The post argues that this can lead people to dismiss useful feedback or leave important code changes unaddressed.

## Approach / What changed

Use positive intent to account for cultural context without dismissing communication's impact; make review comments curious, opinionated, and explicit; ask and answer questions, explain reasoning, and seek education. Treat authors and reviewers as shared owners and collaborators so review becomes part of the team's craft rather than a one-sided critique.

## Takeaways

- Canadian-style hedged feedback may be viewed as patronizing by German or Russian colleagues, while a Japanese colleague may be offended if feedback does not allow an opportunity to save face.
- Positive intent should be assumed as an internal practice, not asserted to someone who reports harm; it can reduce bias without invalidating the impact of a comment.
- A review exchange about a missing permalink test became clearer when the reviewer directly explained that a separate test would expose a regression if the callback changed.

**Tags:** [Code Review](https://yomu.fyi/topic/code-review), [Developer Experience](https://yomu.fyi/topic/developer-experience)

- Source: [Shopify](https://shopify.engineering/code-reviews-communication)
- Source URL: https://shopify.engineering/code-reviews-communication
- Ingested by Yomu: 2026-08-30T13:39:27.522Z

[Read original post](https://shopify.engineering/code-reviews-communication)